feat: re-add simplify= to print.compare.loo (#366)#369
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #369 +/- ##
==========================================
+ Coverage 92.70% 92.72% +0.01%
==========================================
Files 31 31
Lines 3029 3037 +8
==========================================
+ Hits 2808 2816 +8
Misses 221 221 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if 806dcf7 is merged into master:
|
|
Thank you @LeonidasZhak for opening this PR. We had some discussion about whether to include/exclude this argument from |
|
Thanks again @LeonidasZhak for the PR. |
|
Thanks for the guidance. I pushed a follow-up commit that adds focused test coverage for I used AI assistance to help check for issues, refine the code, and run tests. Local checks I ran before pushing:
|
Add a 'simplify' parameter (default TRUE) to print.compare.loo(). When simplify=FALSE, the full comparison table is printed including pointwise ELPD, LOOIC/WAIC, and their standard errors for each model. This restores functionality that was available in previous versions of loo, where users could see the complete model comparison output. Changes: - R/loo_compare.R: Add simplify parameter with documentation - man/loo_compare.Rd: Regenerated by roxygen2 - man/loo-package.Rd: Minor roxygen2 update
875df6f to
806dcf7
Compare
|
I will close this PR as it is not possible for me to differentiate this PR from other fully automated PRs, which are not welcome according to our AI contribution policy. Specifically, as this PR has been created in a batch of > 100 other PRs. In future, I recommend that you write PR description and also comments in the PR with your own words. Furthermore, when proposing new features, it is helpful to propose your suggested solution in the respective Issue before creating a PR. This allows us to guide and support you better. Thank you very much. |
Summary
This follow-up keeps the
simplifyrestoration onprint.compare.loo()and adds the missing focused coverage for the full-output path.Thanks to maintainers
Thanks for the review and for pointing out the missing tests, scope cleanup, and AI disclosure requirement.
Issue or motivation
This PR follows up on #366 by restoring
simplify = FALSEforprint.compare.loo(), while keeping the default simplified output unchanged.Root cause
The earlier branch restored the argument and print-path behavior, but it did not include focused test coverage for the full-output branch and it also carried an unrelated generated-file change.
Change
simplifyinprint.compare.loo()with defaultTRUEprint(comp2, simplify = FALSE)and the full comparison columnsloo-package.RddriftTests
Rscript -e 'devtools::test(filter = "compare", stop_on_failure = TRUE)'R CMD build --no-build-vignettes ._R_CHECK_FORCE_SUGGESTS_=false R CMD check --no-manual --ignore-vignettes --no-build-vignettes loo_2.9.0.9000.tar.gzI used AI assistance to help check for issues, refine the code, and run tests.
Scope
This follow-up does not change the default printed output, does not alter model-comparison calculations, and does not expand the feature beyond the existing
print.compare.loo()path discussed here.