Skip to content

docs(web-player): add PWA and add-to-home-screen guide#554

Merged
stackia merged 2 commits into
mainfrom
cursor/web-player-pwa-docs
Jun 17, 2026
Merged

docs(web-player): add PWA and add-to-home-screen guide#554
stackia merged 2 commits into
mainfrom
cursor/web-player-pwa-docs

Conversation

@stackia

@stackia stackia commented Jun 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • Add a PWA support section to the built-in web player documentation
  • Document how to add the player to the home screen on iOS, Android, and desktop browsers
  • Sync the corresponding English translation

Test plan

  • Review Chinese doc at /guide/web-player
  • Review English doc at /en/guide/web-player
  • Verify platform-specific steps read clearly on mobile and desktop

Document built-in PWA support and platform-specific steps for adding the player to the home screen.
@github-actions

Copy link
Copy Markdown
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-water-0a297bf00-554.eastasia.1.azurestaticapps.net

@stackia stackia marked this pull request as ready for review June 17, 2026 13:14

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d05f8d9883

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/guide/web-player.md Outdated

## PWA 支持与添加到主屏幕

内置 Web 播放器支持 PWA(Progressive Web App)。你可以将播放器页面添加到设备主屏幕,像打开原生应用一样一键进入,获得全屏、沉浸式的观看体验。

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add a manifest before documenting PWA install support

This says the player supports PWA, but the shipped player has no linked web app manifest: rg 'manifest|webmanifest' web-ui src/embedded_web_data.h finds no manifest entry, and web-ui/player.html only sets mobile/Apple meta tags. MDN's installability guide says a web app must include a manifest to be a PWA/installable (https://developer.mozilla.org/en-US/docs/Web/Progressive_web_apps/Guides/Making_PWAs_installable#the_web_app_manifest), so Android/desktop users won't get the documented promoted install/banner flow or the advertised app name/icon metadata; please add and embed the manifest or describe this as a basic Add to Home Screen shortcut instead.

Useful? React with 👍 / 👎.

Clarify iOS and desktop add-to-home-screen paths, document LG webOS support, and sync the English translation.
@stackia stackia marked this pull request as draft June 17, 2026 13:26
@stackia stackia marked this pull request as ready for review June 17, 2026 13:27
@stackia stackia merged commit 33b6427 into main Jun 17, 2026
10 checks passed
@stackia stackia deleted the cursor/web-player-pwa-docs branch June 17, 2026 13:27
@github-actions

Copy link
Copy Markdown
Contributor

Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-water-0a297bf00-554.eastasia.1.azurestaticapps.net

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7355f8d0db

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/guide/web-player.md
3. 选择 **添加到主屏幕** 或 **安装应用**
4. 按提示确认安装

部分浏览器还会在地址栏或页面底部显示安装横幅,点击 **安装** 或 **添加** 即可完成。

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Document HTTPS before promising install prompts

Separate from the missing-manifest comment, even if a manifest is added, this install-banner flow still won't appear for the documented LAN URLs such as http://192.168.1.1:5140/player: Chromium installability requires HTTPS or localhost (https://web.dev/articles/install-criteria), and this daemon's --listen endpoint is plain HTTP unless users add a TLS reverse proxy. Please call out the HTTPS/reverse-proxy requirement or describe Android/desktop HTTP use as a browser shortcut instead, otherwise users following these steps will not see Install app/the banner.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant