gh-141510 Update mapping methods in abstract.c to accept frozendict#150692
Open
da-woods wants to merge 3 commits into
Open
gh-141510 Update mapping methods in abstract.c to accept frozendict#150692da-woods wants to merge 3 commits into
da-woods wants to merge 3 commits into
Conversation
…dict Specifically `PyMapping_GetOptionalItem`, `PyMapping_Keys`, `PyMapping_Values` and `PyMapping_Items`.
Contributor
Author
|
I think this is probably OK to attach to the "frozendict" implementation issue, but I can change it if not (Edit: although I originally linked it to a previous proposal...) |
da-woods
changed the title
vstinner
reviewed
Jun 18, 2026
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
Please update test_mapping_keys_valuesitems() of Lib/test/test_capi/test_abstract.py to test frozendict.
Sadly, PyMapping_GetOptionalItem() doesn't seem to be tested by test_capi so far. But that can be done in another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... as well as dict.
Specifically
PyMapping_GetOptionalItem,PyMapping_Keys,PyMapping_ValuesandPyMapping_Items.