Skip to content

feat: support optimizeEmptyRequests node option handling#154

Open
bjohansebas wants to merge 1 commit into
pillarjs:masterfrom
bjohansebas:feat-support
Open

feat: support optimizeEmptyRequests node option handling#154
bjohansebas wants to merge 1 commit into
pillarjs:masterfrom
bjohansebas:feat-support

Conversation

@bjohansebas

Copy link
Copy Markdown
Member

finalhandler is used as a callback in the router's handler when there’s no error handler or callback (https://github.com/expressjs/express/blob/2eb42059f33d9be6ead3bb813d05aa975283d592/lib/application.js#L154), and for some reason, the response wasn’t finishing. When I realized it, the on-finished callback was never triggered (

onFinished(req, write)
or
if (isFinished(req)) {
), which was the one used to mark the request as completed.

ref: https://openjs-foundation.slack.com/archives/C08QG8K2RTJ/p1757863264523329
ref: expressjs/express#6742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant