ext/openssl: convert stream E_WARNINGs to new stream error API #22318
Open
Girgias wants to merge 4 commits into
Open
ext/openssl: convert stream E_WARNINGs to new stream error API #22318Girgias wants to merge 4 commits into
Girgias wants to merge 4 commits into
Conversation
Girgias
force-pushed
the
2026-06-openssl-stream-error-conv
branch
2 times, most recently
from
6dcf962 to
f0aa120
Compare
Use sites only care if the string matches, thus change the function to be an 'is equal' variant. Also use a zend_string* rather than a char* so that we can use the zend_string equals API.
…ilure cases This prevents some instance of double warnings
Girgias
force-pushed
the
2026-06-openssl-stream-error-conv
branch
from
365b3d0 to
72675f2
Compare
Girgias
changed the title
Member
Author
|
@bukka I have no idea why the test output is different depending on platform. Can you have a look, as me continuing to work on this feels pointless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.