This repository was archived by the owner on Feb 4, 2020. It is now read-only.
Update to faas 0.8.1#7
Open
roomthirteen wants to merge 4 commits into
Open
Conversation
Change the repository of openfaas vendor packages to point to the openfaas github user instead of alexellis account. Signed-off-by: Benjamin Seibert <benjamin.seibert@roomthirteen.de>
Use openfaas 0.8.1 vendors. Signed-off-by: Benjamin Seibert <benjamin.seibert@roomthirteen.de>
To make a function availabe in the 0.8.1 UI we need to set the AvailableReplicas. For now we just use the number of existing replicas. Signed-off-by: Benjamin Seibert <benjamin.seibert@roomthirteen.de>
Implemented the following new handler endpoints: * health * info * secret * update Signed-off-by: Benjamin Seibert <benjamin.seibert@roomthirteen.de>
This was referenced Jan 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @alexellis,
this is my pull request to make faas-rancher compatible with the new faas ui, introducing not only the availableReplicas property in the function list but also all other new provider endpoints. There are two shortfalls:
Missing tests because i do not understand the go testing framework due my limitation in the understanding of the go programming language.
Async rancher service upgrade. Redeploying a function will be done in an async manner due to rancher taking quite some time to upgrade a service. When the redeployment leads to an error, it will leave the rancher service in an inconsistent state instead of doing a rollback which in my opinion is not an issue, since you want to investigate why the redeployment of the function did not work.
What do you think?