fix: use npx to run lex build command for windows compat#2917
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughIn Changesnpx lex CLI invocation
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hello! Thank you for opening your first PR to npmx, @luo2430! 🚀 Here’s what will happen next:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
npx to run lex build command for windows compatnpx to run lex build command for windows compat
|
@luo2430, thank you for your contribution. |
|
@MatteoGabriele Thank you for your reply. In simple terms, it is for maximum cross-platform compatibility. The current version of pnpm on Windows cannot run lex properly. I repeatedly cleaned and ran it several times, but it failed, and even pnpx didn't work. Later, I found that npx can be directly passed. As a non-runtime dependency, I think using npx is also acceptable. I can delete the lex in the devDependencies, and submit another commit. |
|
Thank you @luo2430. I'm checking with someone on the team who has a Windows machine to check this issue, since I'm on a Mac |
|
it does work on my windows machine without so even if it already works fine for some windows machines, this is probably a good change. |
|
I tried deleting lex from devDependencies, but it got an error. Maybe even if you use npx, it's better to keep lex. If you don't want to change this command, I can also write the solution in a place like the readme. Progress: resolved 2300, reused 1850, downloaded 5, added 1, done
. postinstall$ (pnpm rebuild @resvg/resvg-js || true) && vp run generate:lexicons && vp run generate:sprite && nuxt prepar…
│ $ npx lex build --lexicons lexicons --out shared/types/lexicons --clear
│ npm error could not determine executable to run
│ npm error A complete log of this run can be found in: C:\Users\24306\npm-cache\_logs\2026-06-16T21_34_30_062Z-debug-0.log
└─ Failed in 12.4s at C:\Users\24306\git_learning\npmx-dev |
|
@43081j I'm not a huge fan of using npx since it downloads the latest version without respecting versioning, and also skips the minimum release age check. Perhaps if we really want to go that route, we should use |
+1 - if it's not working then it seems to be a bug in pnpm |
🔗 Linked issue
none
🧭 Context
Resolved an issue during
pnpm installon Windows📚 Description
Just add
npxin front oflex build --lexicons lexicons --out shared/types/lexicons --clearinvite.config.ts