fix(cli): quiet third-party optimum logger noise in normal output#904
Open
timenick wants to merge 1 commit into
Open
fix(cli): quiet third-party optimum logger noise in normal output#904timenick wants to merge 1 commit into
timenick wants to merge 1 commit into
Conversation
optimum emits informational WARNINGs that leak into CLI output and interleave with the rich progress spinner -- e.g. "No model type passed for the task image-to-text, that may be mapped to several loading classes ... Defaulting to AutoModelForVision2Seq" when a task maps to several loader classes (surfaced inspecting image-to-text / vision-encoder-decoder models like microsoft/trocr-base-printed). configure_logging now floors noisy third-party loggers (optimum) at ERROR in normal output; with -v/-vv they follow the CLI level so the detail stays available on demand. This is a logging-hygiene fix at the config boundary -- it does not match message text or change how optimum is called. Pre-existing (reproduces before the recent task-detection work).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
optimumemits informational WARNINGs that leak into normal CLI output and interleave with the rich progress spinner. The most visible:It surfaces when inspecting
image-to-text/ vision-encoder-decoder models (e.g.microsoft/trocr-base-printed), mangling the live⠧ Resolving …spinner line.Fix
configure_loggingnow floors noisy third-party loggers (optimum) atERRORin normal output; with-v/-vvthey follow the CLI verbosity level, so the detail stays available on demand.This is a logging-hygiene fix at the configuration boundary — it does not match message text and does not change how
optimumis called.Notes
uv run, not--no-sync) — still reproduces.optimum>=2has been pinned since the initial commit.winml inspect -m microsoft/trocr-base-printedleaks the warning onto the spinner line.-vstill shows the notice.