Refine interface#386
Open
janfaracik wants to merge 1 commit into
Open
Conversation
janfaracik
force-pushed
the
refine-interface
branch
from
1539523 to
ae0a585
Compare
janfaracik
force-pushed
the
refine-interface
branch
from
79db9b7 to
5a3e62c
Compare
mawinter69
suggested changes
Aug 16, 2025
| <div align="right"> | ||
| <input type="button" value="${%Add file}" class="repeatable-add show-if-last" /> | ||
| <input type="button" value="${%Delete}" class="repeatable-delete show-if-not-only" style="margin-left: 1em;" /> | ||
| <button type="button" class="jenkins-button repeatable-add show-if-last"> |
Contributor
There was a problem hiding this comment.
Isn't it more state of the art to have the add button below the section?
Like this:
Though it means a bit of duplication having the button text defined twice
| <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" | ||
| xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form" xmlns:cf="/lib/configfiles"> | ||
| <l:layout permission="${app.MANAGE}" norefresh="true"> | ||
| <l:layout permission="${app.MANAGE}" title="${it.displayName}"> |
Contributor
There was a problem hiding this comment.
Make that type="one-column" ?
| <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define" | ||
| xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form" xmlns:cf="/lib/configfiles"> | ||
| <l:layout permission="${it.CONFIGURE}" norefresh="true"> | ||
| <l:layout permission="${it.CONFIGURE}"> |
Contributor
There was a problem hiding this comment.
Make that type="one-column" ?
Contributor
|
What is a bit suboptimal for me is that you have a separate table for each type of config files. The result is that in each table the width of the columns is different. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refines the interface of the plugin, making use of components from Jenkins Design Library to simplify the interface and bring it inline with the latest LTS of Jenkins.
Highlights
ioniconsBefore
After
Before
After
Before
After
Before
After
Before
After
Before
After
Testing done
Submitter checklist