chore(privatek8s-sponsored): use helmfile state values#7733
Draft
lemeurherve wants to merge 8 commits into
Draft
chore(privatek8s-sponsored): use helmfile state values#7733lemeurherve wants to merge 8 commits into
lemeurherve wants to merge 8 commits into
Conversation
… helmfile state value cloudProvider is not defined (as AKS is our default provider) or if it's value is 'aks'
lemeurherve
commented
May 22, 2026
| networkMonitoring: | ||
| enabled: true | ||
| {{- if .Values }} | ||
| {{- if hasKey .Values.datadog "kubelet" }} |
Contributor
Author
There was a problem hiding this comment.
No mention of any kubelet anywhere except in this template. Removed as it created some lint errors.
lemeurherve
commented
May 22, 2026
Comment on lines
-6
to
-10
| env: | ||
| - name: DD_HOSTNAME | ||
| valueFrom: | ||
| fieldRef: | ||
| fieldPath: spec.nodeName |
Contributor
Author
There was a problem hiding this comment.
Identical section in all cluster datadog values, moved to common datadog values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Could be quite useful when switching clusters.
Ref: