fix: replace O(n^2) regex with linear string search in code block extraction (ReDoS)#6118
Open
Ashutosh0x wants to merge 2 commits into
Open
fix: replace O(n^2) regex with linear string search in code block extraction (ReDoS)#6118Ashutosh0x wants to merge 2 commits into
Ashutosh0x wants to merge 2 commits into
Conversation
…nd_truncate_content (ReDoS)
Contributor
Author
|
Hi @surajksharma07 — this fixes the ReDoS (CWE-1333) reported in #5992. The regex in Behavioral parity maintained — same inputs produce same outputs, just without the hang. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix for #5992 — Replace catastrophic O(n²) regex backtracking in
extract_code_and_truncate_contentwith a linear-time string search.Problem
The regex pattern at line 153 of
code_execution_utils.pyuses multiple.*?groups withre.DOTALL:\\python
rf'(?P.?)({leading_delimiter_pattern})(?P
.?)({trailing_delimiter_pattern})(?P.*?)$'\\
When the input is large and contains no matching delimiters (or partial delimiters), the regex engine tries all possible combinations of how the lazy quantifiers can match, causing O(n²) backtracking that hangs the process.
CWE-1333: Inefficient Regular Expression Complexity (ReDoS)
Fix
Replaced the regex with a simple
str.find()-based approach:This runs in O(n × d) time where d = number of delimiter pairs (typically 2-3), which is effectively O(n).
Testing
The fix preserves the same behavior — extracting the first code block and truncating content after it. The string search approach handles the same edge cases:
Fixes #5992