Add tool for getting code quality findings#2604
Conversation
|
This branch is 2 commits behind I rebased the branch onto current @koesie10 — to update this PR's branch: git fetch https://github.com/advancedresearcharray/github-mcp-server.git koesie10/get-code-quality-finding
git push origin FETCH_HEAD:koesie10/get-code-quality-finding --force-with-leaseCI was already green on the original commit; no review comments to address. The implementation looks good — follows the same pattern as |
|
Opened rebased PR #2616 targeting |
There was a problem hiding this comment.
Pull request overview
Adds first-class support for GitHub “Code Quality” findings to the MCP server by introducing a new read-only tool and grouping it under a dedicated code_quality toolset (including icon + docs/snapshots).
Changes:
- Added
get_code_quality_findingtool to fetch a single code quality finding by number via the REST API. - Introduced the
code_qualitytoolset metadata (with Octicon support) and registered the tool in the server tool inventory. - Updated tool snapshots and generated documentation (README + docs pages) to include the new tool/toolset.
Show a summary per file
| File | Description |
|---|---|
| README.md | Documents the new code_quality toolset and the get_code_quality_finding tool parameters/scopes. |
| pkg/octicons/required_icons.txt | Adds the code-square icon to the required Octicons list. |
| pkg/github/tools.go | Defines ToolsetMetadataCodeQuality and registers GetCodeQualityFinding in AllTools. |
| pkg/github/helper_test.go | Adds a mock route constant for the new code-quality findings endpoint. |
| pkg/github/code_quality.go | Implements get_code_quality_finding tool handler using the REST endpoint. |
| pkg/github/code_quality_test.go | Adds snapshot + behavioral tests for the new tool. |
| pkg/github/toolsnaps/get_code_quality_finding.snap | Adds the tool schema snapshot for CI toolsnap validation. |
| docs/toolsets-and-icons.md | Documents the new Code Quality toolset icon mapping. |
| docs/remote-server.md | Adds the code_quality toolset to the remote server toolset list. |
| docs/feature-flags.md | Updates generated docs content for reviewer description text. |
Copilot's findings
- Files reviewed: 10/12 changed files
- Comments generated: 1
SamMorrowDrums
left a comment
There was a problem hiding this comment.
Looks great, just giving it a final look.
Summary
This adds a new tool to get a single code quality finding by its finding number. It returns the response that the REST API returns.
Why
See internal linked issue. This will allow Copilot to retrieve and fix Code Quality findings
What changed
get_code_quality_findingtool and runs the various scripts to update the docs/retrieve iconcode_qualitytoolset that contains the toolMCP impact
get_code_quality_findingPrompts tested (tool changes only)
Security / limits
reposcope.Tool renaming
deprecated_tool_aliases.goNote: if you're renaming tools, you must add the tool aliases. For more information on how to do so, please refer to the official docs.
Lint & tests
./script/lint./script/testDocs