Percent-encode OTEL_RESOURCE_ATTRIBUTES values for strict OpenTelemetry consumers

[Copilot]

OTEL_RESOURCE_ATTRIBUTES was emitted with raw spaces and legacy backslash escaping, which is non-compliant with the OpenTelemetry env-var format. Strict SDKs can reject the entire resource when any attribute value is malformed, dropping all gh-aw.* attributes on downstream spans.

• Compiler: emit spec-compliant resource attributes

  • Replace backslash escaping with RFC 3986 percent-encoding for OTEL_RESOURCE_ATTRIBUTES values.
  • Encode all non-unreserved bytes, covering spaces, commas, equals signs, backslashes, apostrophes, and similar characters in workflow names / engine IDs.

• JS OTLP consumer: accept the new format

  • Update the in-repo JS parser to percent-decode attribute keys/values before building OTLP resource attributes.
  • Preserve compatibility with the previous gh-aw backslash-escaped format so existing inputs still parse.

• Coverage updates

  • Adjust workflow OTLP tests to assert percent-encoded output for names and engine IDs containing reserved characters.
  • Add JS parsing coverage for percent-encoded OTEL_RESOURCE_ATTRIBUTES alongside legacy escaped input.

Example:

before:
gh-aw.workflow.name=My Workflow,gh-aw.engine.id=claude,eq=demo\test

after:
gh-aw.workflow.name=My%20Workflow,gh-aw.engine.id=claude%2Ceq%3Ddemo%5Ctest

[Copilot]

Pull request overview

Updates gh-aw’s OpenTelemetry resource attribute handling to emit RFC 3986 percent-encoded OTEL_RESOURCE_ATTRIBUTES values (instead of legacy backslash escaping) and teaches the in-repo JavaScript OTLP sender to percent-decode keys/values while remaining compatible with the legacy escape format.

Changes:

• Go compiler: percent-encode all non-unreserved bytes in OTEL_RESOURCE_ATTRIBUTES dynamic values (workflow name, engine ID).
• JS OTLP consumer: decode percent-encoded components while preserving legacy backslash-escape parsing behavior.
• Tests: update/extend coverage to assert percent-encoded emission and percent-decoding.

Show a summary per file

File	Description
pkg/workflow/observability_otlp.go	Switches OTEL resource attribute value encoding to RFC 3986 percent-encoding.
pkg/workflow/observability_otlp_test.go	Updates assertions to expect percent-encoded OTEL_RESOURCE_ATTRIBUTES output.
actions/setup/js/send_otlp_span.cjs	Adds percent-decoding during OTEL_RESOURCE_ATTRIBUTES parsing while keeping legacy escape support.
actions/setup/js/send_otlp_span.test.cjs	Adds a percent-encoded parsing test and updates span resource attribute expectations accordingly.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

• Files reviewed: 4/4 changed files
• Comments generated: 1

[pelikhan]

@copilot use native Go function from go packages to uri encode

[Copilot]

Addressed in 8ee0539. This now uses Go's native URL-encoding helper (url.QueryEscape) with + normalized to %20, which preserves the RFC 3986 percent-encoded output required for OTEL_RESOURCE_ATTRIBUTES.

[pelikhan]

@copilot run pr-finisher skill

[Copilot]

@copilot run pr-finisher skill

Ran the finisher pass. No further code changes were needed; local make fmt, make lint, make test-unit, make test, and make recompile all passed on the current tip (8ee0539). CI on this head still needs a human re-trigger before merge.