perf(core): [SDK Overhead reduction for JVM 2] Short-circuit combined scope breadcrumbs#5541
Open
adinauer wants to merge 5 commits into
Open
perf(core): [SDK Overhead reduction for JVM 2] Short-circuit combined scope breadcrumbs#5541adinauer wants to merge 5 commits into
adinauer wants to merge 5 commits into
Conversation
Avoid allocating and sorting a merged breadcrumb queue when only one component scope has breadcrumbs. This keeps the full merge path for multi-scope breadcrumbs and returns the default write scope queue when all scopes are empty. Co-Authored-By: Claude <noreply@anthropic.com>
📲 Install BuildsAndroid
|
romtsn
reviewed
Jun 12, 2026
8 tasks
adinauer
force-pushed
the
perf/sdk-overhead-jvm-v2
branch
from
51c339c to
7c1a728
Compare
adinauer
requested review from
0xadam-brown,
markushi and
runningcode
as code owners
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
…erf/sdk-overhead-jvm-breadcrumbs-v3
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 22fe488. Configure here.
Contributor
Performance metrics 🚀
|
Avoid allocating merged collection copies when only one combined scope contains values. This extends the breadcrumbs optimization to tags, attributes, extras, and attachments while preserving merge behavior when multiple scopes contribute data. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Stack (SDK Overhead reduction for JVM)
📜 Description
Short-circuit
CombinedScopeView.getBreadcrumbs()when only one component scope contains breadcrumbs.The method now returns the single non-empty scope queue directly, keeps the existing merged/sorted bounded queue path when multiple scopes have breadcrumbs, and uses the configured default write scope when all queues are empty.
💡 Motivation and Context
This implements the breadcrumb portion of AR-08 from the SDK overhead reduction research. The previous code always allocated a temporary list, copied breadcrumbs from all three scopes, sorted them, allocated a bounded queue, and copied them again, even when only one scope had breadcrumbs.
Avoiding that merge path reduces per-event allocation overhead on the common single-scope breadcrumb path.
💚 How did you test it?
./gradlew :sentry:test --tests io.sentry.CombinedScopeViewTest./gradlew spotlessApply apiDump :sentry:test --tests io.sentry.CombinedScopeViewTest📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps
#skip-changelog