Skip to content

fix(expo): declare Google Sign-In ExpoModulesCore dependency#8911

Merged
wobsoriano merged 1 commit into
mainfrom
mike/expo-google-expomodulescore-dep
Jun 18, 2026
Merged

fix(expo): declare Google Sign-In ExpoModulesCore dependency#8911
wobsoriano merged 1 commit into
mainfrom
mike/expo-google-expomodulescore-dep

Conversation

@mikepitre

@mikepitre mikepitre commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds ExpoModulesCore as an explicit dependency of the iOS ClerkGoogleSignIn pod.

Why

After #8901, ClerkGoogleSignInModule.swift became an Expo module and now imports ExpoModulesCore:

import ExpoModulesCore

The ClerkGoogleSignIn podspec did not declare ExpoModulesCore directly, so the generated Podfile could include ExpoModulesCore elsewhere in the app while the ClerkGoogleSignIn pod target still could not import it.

This shows up at Xcode compile time, not during prebuild or pod install:

node_modules/@clerk/expo/ios/ClerkGoogleSignInModule.swift:1:8: error: no such module 'ExpoModulesCore'
import ExpoModulesCore
       ^

Declaring the dependency on the pod that imports it makes CocoaPods wire the module search path correctly for ClerkGoogleSignIn.

Validation

I reproduced the failure locally by installing a test package that matched 3.4.4 but removed only the ExpoModulesCore dependency from ClerkGoogleSignIn.podspec.

Without this change:

  • npx expo prebuild --clean --platform ios passed
  • npx expo run:ios --no-bundler failed with no such module 'ExpoModulesCore'
  • Podfile.lock showed ExpoModulesCore existed globally, but not under ClerkGoogleSignIn

With this change:

  • npx expo prebuild --clean --platform ios passed
  • Podfile.lock showed ClerkGoogleSignIn directly depends on ExpoModulesCore
  • npx expo run:ios --no-bundler passed
  • The app loaded in the iOS simulator through Metro

Also ran:

  • pnpm --filter @clerk/expo format:check
  • git diff --check

Note: local shell reports Node v22.12.0, while the repo asks for >=24.15.0.

@vercel

vercel Bot commented Jun 18, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Jun 18, 2026 2:36am
swingset Ready Ready Preview, Comment Jun 18, 2026 2:36am

Request Review

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

ClerkGoogleSignIn.podspec gains an explicit CocoaPods dependency on ExpoModulesCore. A corresponding Changesets entry records a patch version bump for @clerk/expo describing the iOS build fix.

Changes

iOS podspec dependency fix

Layer / File(s) Summary
ExpoModulesCore dependency and patch changeset
packages/expo/ios/ClerkGoogleSignIn.podspec, .changeset/tiny-google-pods.md
ClerkGoogleSignIn.podspec adds s.dependency 'ExpoModulesCore'; changeset documents the @clerk/expo patch release for this iOS fix.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • clerk/javascript#8901: Also modifies packages/expo/ios/ClerkGoogleSignIn.podspec to fix iOS CocoaPods dependency declarations for the same native Google Sign-In module.

Suggested reviewers

  • wobsoriano

Poem

🐇 Hop hop, a pod was lost,
ExpoModulesCore had a hidden cost.
One line added, the build turns green,
The cleanest fix that I have seen.
Patch it up and ship with glee! 🌿

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The PR title directly describes the main change: adding ExpoModulesCore as an explicit dependency for Google Sign-In in the Expo module, which is the core objective of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@mikepitre mikepitre force-pushed the mike/expo-google-expomodulescore-dep branch from 4736874 to 9d32c83 Compare June 18, 2026 02:34
@changeset-bot

changeset-bot Bot commented Jun 18, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 9d32c83

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@clerk/expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions

github-actions Bot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-06-18T03:02:34.289Z

Summary

Metric Count
Packages analyzed 19
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on 9d32c83.

@mikepitre mikepitre marked this pull request as ready for review June 18, 2026 02:44
@mikepitre mikepitre marked this pull request as draft June 18, 2026 02:59
@mikepitre mikepitre marked this pull request as ready for review June 18, 2026 02:59
@mikepitre mikepitre requested a review from wobsoriano June 18, 2026 03:00
@wobsoriano wobsoriano merged commit 0850fce into main Jun 18, 2026
117 of 120 checks passed
@wobsoriano wobsoriano deleted the mike/expo-google-expomodulescore-dep branch June 18, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants