GH-50194: [C++] Move S3 and AWS-SDK to its own libarrow_s3.so#50195
Draft
raulcd wants to merge 18 commits into
Draft
GH-50194: [C++] Move S3 and AWS-SDK to its own libarrow_s3.so#50195raulcd wants to merge 18 commits into
raulcd wants to merge 18 commits into
Conversation
…umbing for ARROW_S3_MODULE to CI
…f FileSystemFromUri, do not silently ignore non-empty options if underlying FS does not support them and use FileSystemFactoryOptions instead of std::vector<std::pair<std::string, std::any>> everywhere
… tests for FileSystemFromUriAndOptions and add a new one to test old behaviour
Fix linting after rebase Add s3 fs module test for FromUriAndOptionsCredentials and refactor S3Options::FromUri and S3Options::FromUriAndOptions Add tests for FromUriAndOptions credentials Add S3RetryStrategy to options Add option for default_metadata Minor fix
Co-authored-by: Antoine Pitrou <pitrou@free.fr>
…rs to filesystem/util_internal.h. Reject options when appearing both in URI and kv form
This comment was marked as off-topic.
This comment was marked as off-topic.
github-actions
Bot
added
Component: C++
Component: Python
awaiting committer review
One more ARROW_EXPORT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning
Do not merge, this PR is currently only a PoC exercising CI
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?
This PR includes breaking changes to public APIs. (If there are any breaking changes to public APIs, please explain which changes are breaking. If not, you can remove this.)
This PR contains a "Critical Fix". (If the changes fix either (a) a security vulnerability, (b) a bug that caused incorrect or invalid data to be produced, or (c) a bug that causes a crash (even when the API contract is upheld), please provide explanation. If not, you can remove this.)